Conversation
alanshaw
requested changes
May 30, 2025
Member
alanshaw
left a comment
alanshaw
left a comment
There was a problem hiding this comment.
Needs to be marked as a breaking change for interface and validator.
fforbeck
force-pushed
the
feat/multi-verifiers
branch
from
b4e4ea1 to
6c2b5ba
Compare
fforbeck
changed the title
alanshaw
approved these changes
May 30, 2025
Comment on lines
+524
to
+526
| if (verificationResult.error) { | ||
| verificationErrResults.push(verificationResult.error) | ||
| } |
Member
There was a problem hiding this comment.
If not ok then it is error...
Suggested change
| if (verificationResult.error) { | |
| verificationErrResults.push(verificationResult.error) | |
| } | |
| verificationErrResults.push(verificationResult.error) |
Member
Author
There was a problem hiding this comment.
error is optional in the result type.
Merged
fforbeck
pushed a commit
that referenced
this pull request
Jun 2, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>interface: 11.0.0</summary> ## [11.0.0](interface-v10.3.0...interface-v11.0.0) (2025-06-01) ### ⚠ BREAKING CHANGES * resolve multiple verifiers ([#381](#381)) ### Features * resolve multiple verifiers ([#381](#381)) ([6254993](6254993)) </details> <details><summary>server: 11.0.0</summary> ## [11.0.0](server-v10.2.0...server-v11.0.0) (2025-06-01) ### ⚠ BREAKING CHANGES * resolve multiple verifiers ([#381](#381)) ### Features * resolve multiple verifiers ([#381](#381)) ([6254993](6254993)) </details> <details><summary>validator: 10.0.0</summary> ## [10.0.0](validator-v9.1.0...validator-v10.0.0) (2025-06-01) ### ⚠ BREAKING CHANGES * resolve multiple verifiers ([#381](#381)) ### Features * resolve multiple verifiers ([#381](#381)) ([6254993](6254993)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support Multiple Verifiers in DID Resolution
Added support for multiple verifiers in the DID Key resolution process. Previously, the
config.resolveDIDKeymethod would resolve a single verifier, which is fine. However, if we decide to resolvedid:keyfrom adid:plcdocument, we need to resolve all verifiers traversed the returned list to find one that successfully verifies the signature.Main Changes
verifyAuthorizationfunction inpackages/validator/src/lib.jsto handle multiple verifiers returned byresolveDIDKeyRelated: storacha/project-tracking#463