Temp/change preview dimension #464
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demetriusfeijoo
changed the base branch from
main
to
feat/change-preview-dimension
demetriusfeijoo
commented
Jul 25, 2025
...ugin/src/messaging/pluginMessage/containerToPluginMessage/PreviewDimensionResponseMessage.ts
Outdated
Show resolved
Hide resolved
Dawntraoz
approved these changes
Jul 28, 2025
packages/field-plugin/src/createFieldPlugin/createPluginActions/callbackQueue.ts
Outdated
Show resolved
Hide resolved
packages/field-plugin/src/createFieldPlugin/createPluginActions/callbackQueue.ts
Outdated
Show resolved
Hide resolved
packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginActions.ts
Outdated
Show resolved
Hide resolved
packages/field-plugin/src/createFieldPlugin/createPluginActions/createPluginActions.ts
Outdated
Show resolved
Hide resolved
|
Hey @Dawntraoz 🙌 Thanks for reviewing it! 🫶 I'll apply the changes, now, so we can unlock the task 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Possible solution for: https://github.com/storyblok/field-plugin/pull/463/files#r2231327295
Screen.Recording.2025-07-25.at.12.44.52.mov
PS: Tests should be fixed and some created.