Conversation
…s for improved readability
… types and improve related tests
…cross IP asset and license request types
…ult value of 100 across group-related requests
…rror messages for clarity
…0 and enhance related tests for clarity
bonnie57
requested review from
AndyBoWu,
DonFungible,
LeoHChen,
allenchuang,
edisonz0718,
jacob-tucker,
limengformal and
lucas2brh
as code owners
…0 in IP asset requests and enhance related tests for clarity
jacob-tucker
previously approved these changes
Sep 26, 2025
…nueShare values in group and IP asset tests for improved accuracy and consistency
… and license tests for consistency
lucas2brh
previously approved these changes
Sep 26, 2025
…th other configurations
lucas2brh
approved these changes
Sep 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the following field, make it optional and give a default value:
And add related unit tests to coverage.
Question
I don't give the default value of
expectMinimumGroupRewardShare; I am not sure what value I should provide.Confirmed with @jacob-tucker , we don't need to give the default value of
expectMinimumGroupRewardShare.