-
Notifications
You must be signed in to change notification settings - Fork 12
feature branch: add Psalm static analysis #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8906b3c to
d853281
Compare
9595646 to
6c4b6fc
Compare
ab010e0 to
68e38b5
Compare
b1d6580 to
9e2c91d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds Psalm static analysis tooling to the project as a complementary analysis tool alongside the existing PHPStan. The integration includes configuration, Composer dependencies, and task definitions for both Castor and Make build systems.
Changes:
- Added Psalm static analysis tool with configuration
- Integrated Psalm into existing lint workflows
- Updated build automation to include Psalm checks
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| psalm.xml | Adds Psalm configuration with error level 1 and project file definitions |
| composer.json | Adds vimeo/psalm dependency to require-dev |
| castor.php | Adds psalm task and integrates it into lint_all workflow |
| Makefile | Adds psalm target and integrates it into lint workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 13 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
87ac18a to
d0161b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Add Psalm to composer dependencies - Add psalm configuration file - Add Psalm task to castor and make commands - Add Psalm to GitHub Actions workflow - Add Psalm to CI and lint workflows
Potential errors found by Psalm and fixed in the main branch
Links
Status