Skip to content

Conversation

@COil
Copy link
Member

@COil COil commented Feb 5, 2025

Potential errors found by Psalm and fixed in the main branch

Links

Status

Q A
Branch? feature-branch
Cleanup? no
Bug fix? no
Fixed tickets NA
New feature? yes
Doc added? yes
Tests pass? not yet
Deprecations? no
License MIT

@COil COil added the DX Developer Experience label Feb 5, 2025
@COil COil self-assigned this Feb 5, 2025
@COil COil force-pushed the psalm branch 4 times, most recently from 8906b3c to d853281 Compare February 7, 2025 21:06
@COil COil force-pushed the psalm branch 2 times, most recently from 9595646 to 6c4b6fc Compare February 10, 2025 17:04
@COil COil changed the title feat: add Psalm static analysis feature branch: add Psalm static analysis Feb 10, 2025
@COil COil added the feature branch Feeature branch demo label Feb 10, 2025
@COil COil force-pushed the psalm branch 3 times, most recently from ab010e0 to 68e38b5 Compare February 11, 2025 20:43
@COil COil force-pushed the psalm branch 2 times, most recently from b1d6580 to 9e2c91d Compare February 20, 2025 21:38
Copilot AI review requested due to automatic review settings January 17, 2026 18:54
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds Psalm static analysis tooling to the project as a complementary analysis tool alongside the existing PHPStan. The integration includes configuration, Composer dependencies, and task definitions for both Castor and Make build systems.

Changes:

  • Added Psalm static analysis tool with configuration
  • Integrated Psalm into existing lint workflows
  • Updated build automation to include Psalm checks

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.

File Description
psalm.xml Adds Psalm configuration with error level 1 and project file definitions
composer.json Adds vimeo/psalm dependency to require-dev
castor.php Adds psalm task and integrates it into lint_all workflow
Makefile Adds psalm target and integrates it into lint workflow

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@COil COil requested a review from Copilot January 17, 2026 20:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@COil COil force-pushed the psalm branch 2 times, most recently from 87ac18a to d0161b6 Compare January 17, 2026 21:34
@COil COil requested a review from Copilot January 17, 2026 21:35
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

COil added 2 commits January 17, 2026 22:56
- Add Psalm to composer dependencies
- Add psalm configuration file
- Add Psalm task to castor and make commands
- Add Psalm to GitHub Actions workflow
- Add Psalm to CI and lint workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX Developer Experience feature branch Feeature branch demo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants