chore: backport of Psalm fix #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR backports Psalm static analysis fixes from another repository to improve type safety and code quality. The changes focus on adding type hints, interface implementation annotations, and class finalization to help static analysis tools better understand the codebase.
Changes:
- Added
#[\Override]attributes to methods implementing parent class/interface methods - Added PHPDoc type hints for better static analysis in test files and controllers
- Made
UserandUserRepositoryclasses final to prevent unintended inheritance
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Integration/Twig/Extension/RoutingExtensionTest.php | Added type hint for RoutingExtension variable |
| tests/Integration/Entity/UserTest.php | Added type hint for EntityManagerInterface variable |
| src/Twig/Extension/EnvExtension.php | Added Override attribute to getGlobals method |
| src/Story/AppStory.php | Added Override attribute to build method |
| src/Repository/UserRepository.php | Made class final |
| src/Form/Type/RegisterForm.php | Added Override attributes to buildForm and configureOptions methods |
| src/Factory/UserFactory.php | Added Override attributes to class and defaults methods |
| src/Entity/User.php | Made class final and added Override attributes to interface methods |
| src/Controller/FormAction.php | Added type hint for RegisterFormDto variable |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
COil
force-pushed
the
chore/backport-psalm-fixes
branch
from
85ece05 to
0ca7dd1
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.