Ondra fix dynamic ip fw #329
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where FW was not remapped correctly with the dynamic_ips setting. The remapping was done on the self._firewall, which is the collection of rules changed during the episode. However, during the reset in the end of the epiA bug was fixed where the firewall (FW) was not remapped correctly when using the dynamic_ips setting. The remapping occurred on the
self._firewall, which contains the rules modified during the episode. However, at the end of the episode, during the reset, this modified version was overwritten with the original FW version that had not been remapped.sode this is overwritten with the original version of the FW, which was not remapped