Skip to content

Ondra fix dynamic ip fw #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrej-lukas merged 2 commits into from
Jul 3, 2025
Merged

Ondra fix dynamic ip fw #329

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5818500
Log dynamic IP change use
ondrej-lukas Jul 3, 2025
5ad41bd
re-map _firewall_original (not the one changed during the episode)
ondrej-lukas Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AIDojoCoordinator/coordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,6 +378,7 @@ async def start_tasks(self):
else:
self._global_defender = None
self._use_dynamic_ips = self.task_config.get_use_dynamic_addresses()
self.logger.info(f"Change IP every episode set to: {self._use_dynamic_ips}")
self._rewards = self.task_config.get_rewards(["step", "success", "fail", "false_positive"])
self.logger.info(f"Rewards set to:{self._rewards}")
self._min_required_players = self.task_config.get_required_num_players()
Expand Down
14 changes: 7 additions & 7 deletions AIDojoCoordinator/worlds/NSEGameCoordinator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,6 @@ def _create_new_network_mapping(self)->tuple:
fake = self._faker_object
mapping_nets = {}
mapping_ips = {}

# generate mapping for networks
private_nets = []
for net in self._networks.keys():
Expand Down Expand Up @@ -369,13 +368,14 @@ def _create_new_network_mapping(self)->tuple:
new_self_networks[mapping_nets[net]].add(mapping_ips[ip])
self._networks = new_self_networks

#self._firewall
new_self_firewall = {}
for ip, dst_ips in self._firewall.items():
new_self_firewall[mapping_ips[ip]] = set()
#self._firewall_original (we do not care about the changes done during the episode)
new_self_firewall_original = {}
for ip, dst_ips in self._firewall_original.items():
new_self_firewall_original[mapping_ips[ip]] = set()
for dst_ip in dst_ips:
new_self_firewall[mapping_ips[ip]].add(mapping_ips[dst_ip])
self._firewall = new_self_firewall
new_self_firewall_original[mapping_ips[ip]].add(mapping_ips[dst_ip])
self.logger.debug(f"New FW: {new_self_firewall_original}")
self._firewall_original = new_self_firewall_original

#self._ip_to_hostname
new_self_ip_to_hostname = {}
Expand Down