Add miri workflow #2023
Merged
Add miri workflow #2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shourya742
force-pushed
the
2025-12-11-add-miri-workflow
branch
from
7869168 to
ca70e5e
Compare
GitGab19
approved these changes
Dec 17, 2025
plebhash
approved these changes
Dec 17, 2025
…ding mutable access to same data region twice which was causing miri to flag it
Shourya742
force-pushed
the
2025-12-11-add-miri-workflow
branch
from
ca70e5e to
37d8b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces Miri into our workflow for validating undefined-behavior in our core crates. We are starting with
noise_sv2andbuffer_sv2, as these are the only crates currently making use ofunsafeRust.As part of this work:
buffer_sv2issue reported here: Fix Miri-detected undefined behavior in buffer_sv2 #1964.noise_sv2tests as ignored under Miri, since they trigger C FFI paths that Miri cannot evaluate.This PR represents the foundational integration of Miri into SRI. Going forward, we plan to expand coverage across more crates, increase test depth, and leverage Miri to catch additional UB and edge-case behavior early in development.
Closes: #1964