channels-sv2: refine client share accounting counters#2114
Merged
plebhash merged 1 commit intostratum-mining:mainfrom Mar 19, 2026
Merged
Conversation
GitGab19
reviewed
Mar 12, 2026
plebhash
force-pushed
the
2026-03-12-client-share-accounting-refinement
branch
from
9610e34 to
6529720
Compare
GitGab19
approved these changes
Mar 13, 2026
Member
Author
|
reverting to draft to avoid merging by accident will make it ready again once companion stratum-mining/sv2-apps#328 is unblocked by stratum-mining/sv2-apps#281 |
plebhash
force-pushed
the
2026-03-12-client-share-accounting-refinement
branch
from
6529720 to
e93e347
Compare
replace shares_accepted with acknowledged_shares, validated_shares, and rejected_shares add on_share_rejection and delegate it from extended and standard channels update on_share_acknowledgement and track_validated_share to increment the new counters add getters for acknowledged, validated, and rejected shares
plebhash
force-pushed
the
2026-03-12-client-share-accounting-refinement
branch
from
e93e347 to
572340c
Compare
Shourya742
reviewed
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #2107
companion stratum-mining/sv2-apps#328