client share accounting refinement

[plebhash]

companion stratum-mining/stratum#2114

[gimballock]

For when the monitoring/metrics commits come back (via #2119): the earlier rename of validated_shares to submitted_shares in the app layer collides with the existing shares_submitted field on ServerExtendedChannelInfo (which counts shares sent to upstream — a different concept). Recommend keeping validated_shares consistently across both layers to avoid confusion in dashboards and PromQL queries.

[gimballock]

Note for when the metrics rename commits come back: snapshot_cache.rs::update_metrics() also references sv2_server_shares_accepted_total / sv2_client_shares_accepted_total and has stale-label-removal logic for those metric names. Will need updating alongside prometheus_metrics.rs and http_server.rs. Happy to help with that integration.

[gimballock]

Once all three counters land in Prometheus, inflight shares (submitted but not yet resolved) can be monitored via the invariant: inflight = validated - acknowledged - rejected. Divergence from >= 0 would likely indicate some kind of issue.

[gimballock]

Beyond passing ci checks this LGTM

[plebhash]

@gimballock thanks

I assume all the notes above are also covered by stratum-mining/stratum#2119 (comment)?

if not, I'd encourage you to move any missing info to that issue, because taking those notes here means they're much likely to be forgotten once the PR is merged

[gimballock]

Good call — I've already posted the server-side refinement guidance on stratum-mining/stratum#2119. Let me move the remaining notes there too:

• the submitted_shares / validated_shares naming concern
• the snapshot_cache.rs update needed when the metrics rename lands

[Shourya742]

ACK