Skip to content

Conversation

@labuladong
Copy link
Member

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Copilot AI review requested due to automatic review settings June 18, 2025 02:37
@labuladong labuladong requested review from a team as code owners June 18, 2025 02:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces optional metadata annotations and labels for the PVCs used in BookKeeper storage, enhancing configuration flexibility for journal and ledger volumes.

  • Updated values.yaml files for both sn-platform and sn-platform-slim to include example metadata comments.
  • Updated bookkeeper-cluster.yaml templates in both charts to conditionally render metadata for PVCs based on provided configuration.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
charts/sn-platform/values.yaml Added commented sample metadata configurations for journal and ledger.
charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml Added conditional rendering for PVC metadata in journal and ledger sections.
charts/sn-platform-slim/values.yaml Added commented sample metadata configurations for journal and ledger.
charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml Added conditional rendering for PVC metadata in journal and ledger sections.

@github-actions
Copy link

@labuladong:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jun 18, 2025
@labuladong labuladong merged commit 1d43b5b into master Jun 18, 2025
3 checks passed
@labuladong labuladong deleted the donglai/bk/pvc-annotation branch June 18, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-info-missing This pr needs to mark a document option in description

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants