Skip to content

Support adding annotation to pvc #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labuladong merged 1 commit into from
Jun 18, 2025
Merged

Support adding annotation to pvc #1226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions charts/sn-platform-slim/templates/bookkeeper/bookkeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,17 @@ spec:
journal:
numVolumes: {{ .Values.bookkeeper.volumes.journal.numVolumes | default 1 }}
numDirsPerVolume: {{ .Values.bookkeeper.volumes.journal.numDirsPerVolume | default 1 }}
{{- if .Values.bookkeeper.volumes.journal.metadata }}
metadata:
{{- if .Values.bookkeeper.volumes.journal.metadata.annotations }}
annotations:
{{ toYaml .Values.bookkeeper.volumes.journal.metadata.annotations | indent 10 }}
{{- end }}
{{- if .Values.bookkeeper.volumes.journal.metadata.labels }}
labels:
{{ toYaml .Values.bookkeeper.volumes.journal.metadata.labels | indent 10 }}
{{- end }}
{{- end }}
volumeClaimTemplate:
accessModes:
{{- range .Values.bookkeeper.volumes.journal.accessModes }}
Expand All @@ -143,6 +154,17 @@ spec:
ledger:
numVolumes: {{ .Values.bookkeeper.volumes.ledgers.numVolumes | default 1 }}
numDirsPerVolume: {{ .Values.bookkeeper.volumes.ledgers.numDirsPerVolume | default 1 }}
{{- if .Values.bookkeeper.volumes.ledgers.metadata }}
metadata:
{{- if .Values.bookkeeper.volumes.ledgers.metadata.annotations }}
annotations:
{{ toYaml .Values.bookkeeper.volumes.ledgers.metadata.annotations | indent 10 }}
{{- end }}
{{- if .Values.bookkeeper.volumes.ledgers.metadata.labels }}
labels:
{{ toYaml .Values.bookkeeper.volumes.ledgers.metadata.labels | indent 10 }}
{{- end }}
{{- end }}
volumeClaimTemplate:
accessModes:
{{- range .Values.bookkeeper.volumes.ledgers.accessModes }}
Expand Down
12 changes: 12 additions & 0 deletions charts/sn-platform-slim/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -907,6 +907,12 @@ bookkeeper:
# mountOptions:
# extraParameters:
# iopsPerGB: "50"
# metadata to add onto PVCs for journal storage
# metadata:
# annotations:
# example.com/annotation-key: "annotation-value"
# labels:
# example.com/label-key: "label-value"
ledgers:
# It determines the directory of ledgers data
numVolumes: 1
Expand All @@ -930,6 +936,12 @@ bookkeeper:
# mountOptions:
# extraParameters:
# iopsPerGB: "50"
# metadata to add onto PVCs for ledgers storage
# metadata:
# annotations:
# example.com/annotation-key: "annotation-value"
# labels:
# example.com/label-key: "label-value"
jvm:
# BookKeeper Operator will automatically generate the JVM memory options based on the Pod memory size. You can override this by entering a new value.
memoryOptions: []
Expand Down
22 changes: 22 additions & 0 deletions charts/sn-platform/templates/bookkeeper/bookkeeper-cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,17 @@ spec:
journal:
numVolumes: {{ .Values.bookkeeper.volumes.journal.numVolumes | default 1 }}
numDirsPerVolume: {{ .Values.bookkeeper.volumes.journal.numDirsPerVolume | default 1 }}
{{- if .Values.bookkeeper.volumes.journal.metadata }}
metadata:
{{- if .Values.bookkeeper.volumes.journal.metadata.annotations }}
annotations:
{{ toYaml .Values.bookkeeper.volumes.journal.metadata.annotations | indent 10 }}
{{- end }}
{{- if .Values.bookkeeper.volumes.journal.metadata.labels }}
labels:
{{ toYaml .Values.bookkeeper.volumes.journal.metadata.labels | indent 10 }}
{{- end }}
{{- end }}
volumeClaimTemplate:
accessModes:
{{- range .Values.bookkeeper.volumes.journal.accessModes }}
Expand All @@ -143,6 +154,17 @@ spec:
ledger:
numVolumes: {{ .Values.bookkeeper.volumes.ledgers.numVolumes | default 1 }}
numDirsPerVolume: {{ .Values.bookkeeper.volumes.ledgers.numDirsPerVolume | default 1 }}
{{- if .Values.bookkeeper.volumes.ledgers.metadata }}
metadata:
{{- if .Values.bookkeeper.volumes.ledgers.metadata.annotations }}
annotations:
{{ toYaml .Values.bookkeeper.volumes.ledgers.metadata.annotations | indent 10 }}
{{- end }}
{{- if .Values.bookkeeper.volumes.ledgers.metadata.labels }}
labels:
{{ toYaml .Values.bookkeeper.volumes.ledgers.metadata.labels | indent 10 }}
{{- end }}
{{- end }}
volumeClaimTemplate:
accessModes:
{{- range .Values.bookkeeper.volumes.journal.accessModes }}
Expand Down
12 changes: 12 additions & 0 deletions charts/sn-platform/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -982,6 +982,12 @@ bookkeeper:
# mountOptions:
# extraParameters:
# iopsPerGB: "50"
# metadata to add onto PVCs for journal storage
# metadata:
# annotations:
# example.com/annotation-key: "annotation-value"
# labels:
# example.com/label-key: "label-value"
ledgers:
# It determines the directory of ledgers data
numVolumes: 1
Expand All @@ -1005,6 +1011,12 @@ bookkeeper:
# mountOptions:
# extraParameters:
# iopsPerGB: "50"
# metadata to add onto PVCs for ledgers storage
# metadata:
# annotations:
# example.com/annotation-key: "annotation-value"
# labels:
# example.com/label-key: "label-value"
jvm:
# BookKeeper Operator will automatically generate the JVM memory options based on the Pod memory size. You can override this by entering a new value.
memoryOptions: []
Expand Down
Loading