Skip to content

fix(testutil): handle GetNamespaces errors in EnsureNamespace #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 5 commits into from
Closed

fix(testutil): handle GetNamespaces errors in EnsureNamespace #66

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee4450f
Initial plan
Copilot Jan 5, 2026
03a732a
fix(testutil): improve error handling in EnsureNamespace function
Copilot Jan 5, 2026
3709c45
docs(testutil): improve error handling documentation in EnsureNamespace
Copilot Jan 5, 2026
0f183fd
refactor(testutil): use case-insensitive error pattern matching
Copilot Jan 5, 2026
d0635e0
style(testutil): apply go fmt formatting and update comments
Copilot Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions pkg/mcp/internal/testutil/pulsar.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"context"
"fmt"
"net/http"
"strings"
"time"

"github.com/apache/pulsar-client-go/pulsaradmin"
Expand All @@ -29,10 +30,10 @@ import (

// PulsarTestHelper provides helper functions for Pulsar E2E testing.
type PulsarTestHelper struct {
adminClient pulsaradmin.Client
adminURL string
serviceURL string
httpClient *http.Client
adminClient pulsaradmin.Client
adminURL string
serviceURL string
httpClient *http.Client
}

// NewPulsarTestHelper creates a new PulsarTestHelper.
Expand Down Expand Up @@ -106,17 +107,37 @@ func (h *PulsarTestHelper) EnsureNamespace(ctx context.Context, tenant, namespac

// Check if namespace exists
namespaces, err := h.adminClient.Namespaces().GetNamespaces(tenant)
if err == nil {
if err != nil {
// If we cannot list namespaces, we'll try to create it anyway.
// This could be due to permission issues or other transient errors.
// The CreateNamespace call will fail with a proper error if there's a real issue.
} else {
// Successfully retrieved namespaces, check if ours exists
for _, ns := range namespaces {
if ns == fullNamespace {
return nil // Already exists
}
}
}

// Create namespace
// Create namespace - this will fail if it already exists or if there are permission/connection issues
err = h.adminClient.Namespaces().CreateNamespace(fullNamespace)
if err != nil {
// Check if the error is because namespace already exists.
// The Pulsar admin client doesn't provide typed errors, so we check the error message.
// This is a best-effort approach for test utilities - we check for common patterns:
// - "already exists" (common HTTP API message)
// - "alreadyexists" (possible gRPC/protobuf message)
// - "409" (HTTP Conflict status code)
// - "conflict" (HTTP status text)
// Using case-insensitive matching for robustness
errMsg := strings.ToLower(err.Error())
if strings.Contains(errMsg, "already exists") ||
strings.Contains(errMsg, "alreadyexists") ||
strings.Contains(errMsg, "409") ||
strings.Contains(errMsg, "conflict") {
return nil // Namespace already exists, which is what we want
}
return fmt.Errorf("failed to create namespace %s: %w", fullNamespace, err)
}

Expand Down