Skip to content

feat: support iam related arguments for ServiceAccountBinding#121

Merged
jiangpengcheng merged 7 commits intomainfrom
update_sab
Dec 16, 2025
Merged

feat: support iam related arguments for ServiceAccountBinding#121
jiangpengcheng merged 7 commits intomainfrom
update_sab

Conversation

@jiangpengcheng
Copy link
Member

No description provided.

@jiangpengcheng jiangpengcheng requested a review from a team as a code owner June 5, 2025 08:19
@freeznet freeznet requested a review from Copilot June 8, 2025 08:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for two new IAM-related fields (enable_iam_account_creation and aws_assume_role_arns) to the ServiceAccountBinding Terraform resource and data source, updates documentation, provider descriptions, and bumps the cloud-api-server dependency.

  • Introduce enable_iam_account_creation (bool) and aws_assume_role_arns (list of strings) in resource and data source schemas and map them to the CR spec
  • Update provider descriptions and Terraform docs for both resource and data source
  • Bump github.com/streamnative/cloud-api-server to v1.36.0

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
go.mod Bumped cloud-api-server module from v1.35.2 to v1.36.0
docs/resources/service_account_binding.md Documented new optional fields aws_assume_role_arns and enable_iam_account_creation
docs/data-sources/service_account_binding.md Documented new read-only attributes for IAM support
cloud/resource_service_account_binding.go Added schema entries, create/read logic, and CR spec mapping for new fields
cloud/provider.go Added descriptions for the new parameters
cloud/data_source_service_account_binding.go Added computed schema entries and read mapping for new fields
Comments suppressed due to low confidence (1)

cloud/resource_service_account_binding.go:102

  • New schema fields enable_iam_account_creation and aws_assume_role_arns lack corresponding unit or acceptance tests. Consider adding tests to verify their behavior.
"enable_iam_account_creation": {

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jiangpengcheng jiangpengcheng force-pushed the update_sab branch 2 times, most recently from 4e2917a to 8dbe24a Compare December 10, 2025 02:05
Copy link
Member

@freeznet freeznet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add tests for service account binding?

@jiangpengcheng
Copy link
Member Author

could you please add tests for service account binding?

added

@jiangpengcheng jiangpengcheng merged commit a3cfdee into main Dec 16, 2025
1 check passed
@jiangpengcheng jiangpengcheng deleted the update_sab branch December 16, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants