refactor: Remove unnecessary globbing from tsconfig files
#3287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistent tab size of 2.
github-actions
bot
added
network
mondoreale
commented
Dec 11, 2025
| "noImplicitOverride": false | ||
| }, | ||
| "include": [ | ||
| "src/**/*" |
Contributor
Author
There was a problem hiding this comment.
This file is badly indented. #3285 fixes it.
juslesan
approved these changes
Dec 11, 2025
teogeb
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request standardizes the
includepatterns in varioustsconfigfiles across multiple packages. The main change is replacing glob patterns like"src/**/*"with just"src"(and similar for other folders), simplifying the TypeScript configuration and potentially improving build performance and consistency.Changes
The most important changes are:
Standardization of
includepatterns in tsconfig files:tsconfig.jest.jsonandtsconfig.node.jsonfiles across packages (such asautocertifier-client,autocertifier-server,cdn-location,cli-tools,dht,geoip-location,node,proto-rpc,sdk,browser-test-runner, andtest-utils) to use direct folder references (e.g.,"src","bin","test","generated","data-generation") instead of recursive glob patterns (e.g.,"src/**/*").Minor related adjustments:
excludepatterns and removed unnecessary file references in thesdkpackage'stsconfigfiles for consistency.