Skip to content

Conversation

@mondoreale
Copy link
Contributor

@mondoreale mondoreale commented Dec 14, 2025

This pull request removes the noImplicitOverride option from several TypeScript configuration files across multiple packages.

Note

Previously, noImplicitOverride was explicitly set to false across the app. This was not a design choice, but a workaround: the auto-generated protobuf types were incompatible with noImplicitOverride, and there was no proper isolation at the tsconfig level to scope that limitation. As a result, stricter typing guarantees were relaxed globally.

Change in this PR is a step towards bringing the restriction back, making the types stricter again.

Changes

TypeScript configuration cleanup:

  • Removed the noImplicitOverride option from tsconfig.node.json files in autocertifier-server, cdn-location, and geoip-location packages. [1] [2] [3]
  • Removed the noImplicitOverride option from tsconfig.karma.json files in dht, proto-rpc, trackerless-network, and utils packages. [1] [2] [3] [4]
  • Removed the noImplicitOverride option from tsconfig.jest.json in the cli-tools package.

@github-actions github-actions bot added network Related to Network Package cli-tools Related to CLI Tools Package dht Related to DHT package utils proto-rpc labels Dec 14, 2025
@mondoreale mondoreale changed the title refactor: Restore strict noImplicitOverride for **packages with no protobuf code** refactor: Restore strict noImplicitOverride for packages with no protobuf code Dec 14, 2025
@mondoreale mondoreale marked this pull request as ready for review December 14, 2025 17:16
@mondoreale mondoreale force-pushed the enable-noImplicitOverride-for-the-protoless branch from fcf240f to 19e6994 Compare December 14, 2025 17:34
@mondoreale mondoreale changed the base branch from clean-generated to main December 14, 2025 17:34
@mondoreale mondoreale merged commit 1b2eb13 into main Dec 14, 2025
21 checks passed
@mondoreale mondoreale deleted the enable-noImplicitOverride-for-the-protoless branch December 14, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli-tools Related to CLI Tools Package dht Related to DHT package network Related to Network Package proto-rpc utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants