refactor: Restore strict noImplicitOverride for packages with no protobuf code
#3294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the
noImplicitOverrideoption from several TypeScript configuration files across multiple packages.Note
Previously,
noImplicitOverridewas explicitly set tofalseacross the app. This was not a design choice, but a workaround: the auto-generated protobuf types were incompatible withnoImplicitOverride, and there was no proper isolation at the tsconfig level to scope that limitation. As a result, stricter typing guarantees were relaxed globally.Change in this PR is a step towards bringing the restriction back, making the types stricter again.
Changes
TypeScript configuration cleanup:
noImplicitOverrideoption fromtsconfig.node.jsonfiles inautocertifier-server,cdn-location, andgeoip-locationpackages. [1] [2] [3]noImplicitOverrideoption fromtsconfig.karma.jsonfiles indht,proto-rpc,trackerless-network, andutilspackages. [1] [2] [3] [4]noImplicitOverrideoption fromtsconfig.jest.jsonin thecli-toolspackage.