Skip to content

Conversation

@mondoreale
Copy link
Contributor

This pull request updates TypeScript configuration to adjust how project reference redirects are handled. The main change is moving the disableSourceOfProjectReferenceRedirect option from the root tsconfig.node.json to the more specific packages/cli-tools/tsconfig.node.json configuration.

In essence, we don't want it enabled globally, and since the cli-tools is the only package that uses a private resource from another package (that it references) we can go with more accurate setup.

Changes

TypeScript configuration changes:

  • Removed disableSourceOfProjectReferenceRedirect from the root tsconfig.node.json to avoid globally disabling project reference redirects.
  • Added disableSourceOfProjectReferenceRedirect: true to packages/cli-tools/tsconfig.node.json so that this setting only applies to the CLI tools package, providing more granular control.

…e only

That's the only package that uses private fields from another of our packages – `Message#streamMessage` from `sdk`.
@github-actions github-actions bot added the cli-tools Related to CLI Tools Package label Dec 15, 2025
@mondoreale mondoreale requested a review from Copilot December 15, 2025 10:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors TypeScript project reference configuration by scoping the disableSourceOfProjectReferenceRedirect option to only the package that requires it, rather than applying it globally. The cli-tools package is currently the only one that accesses private resources from its referenced packages, making it the appropriate place for this setting.

Key Changes:

  • Removed global disableSourceOfProjectReferenceRedirect setting from root TypeScript configuration
  • Added package-specific disableSourceOfProjectReferenceRedirect: true to cli-tools configuration for more granular control

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tsconfig.node.json Removed the global disableSourceOfProjectReferenceRedirect option to avoid affecting all packages
packages/cli-tools/tsconfig.node.json Added disableSourceOfProjectReferenceRedirect: true to compilerOptions to maintain the needed behavior for this specific package

The changes are clean, syntactically correct, and align well with the stated purpose. The refactoring improves configuration accuracy by applying the setting only where needed rather than globally.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mondoreale
Copy link
Contributor Author

I'mma merge this in order to proceed with other stuff. This does not cause any output/logic differences.

@mondoreale mondoreale merged commit 728d1e6 into main Dec 15, 2025
48 of 49 checks passed
@mondoreale mondoreale deleted the scope-disableSourceOfProjectReferenceRedirect-to-cli-tools-only branch December 15, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli-tools Related to CLI Tools Package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants