fix(assert): stabilize relative error calculation in InEpsilon#1847
Open
Davi-y08 wants to merge 1 commit intostretchr:masterfrom
Open
fix(assert): stabilize relative error calculation in InEpsilon#1847Davi-y08 wants to merge 1 commit intostretchr:masterfrom
Davi-y08 wants to merge 1 commit intostretchr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix relative error calculation for small expected values in InEpsilon.
The previous implementation normalized only by the expected value, which could
inflate relative error when expected was small. This change normalizes by the
maximum absolute value, improving numerical stability without changing the
semantics of the base code.
For the tests, i used the below values:
{0.1, 0.14, 0.4}