Skip to content

fix(assert): stabilize relative error calculation in InEpsilon #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Davi-y08 wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

fix(assert): stabilize relative error calculation in InEpsilon #1847

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion assert/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1570,7 +1570,8 @@ func calcRelativeError(expected, actual interface{}) (float64, error) {
return 0, errors.New("actual value must not be NaN")
}

return math.Abs(af-bf) / math.Abs(af), nil
denom := math.Max(math.Abs(af), math.Abs(bf))
return math.Abs(af-bf) / denom, nil
}

// InEpsilon asserts that expected and actual have a relative error less than epsilon
Expand Down
3 changes: 2 additions & 1 deletion assert/assertions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2459,6 +2459,7 @@ func TestInEpsilon(t *testing.T) {
{uint64(100), uint8(101), 0.01},
{0.1, -0.1, 2},
{0.1, 0, 2},
{0.1, 0.14, 0.4},
{math.NaN(), math.NaN(), 1},
{time.Second, time.Second + time.Millisecond, 0.002},
}
Expand Down Expand Up @@ -4209,4 +4210,4 @@ func TestNotErrorAsWithErrorTooLongToPrint(t *testing.T) {
Contains(t, mockT.errorString(), `
in chain: "long: [0 0 0`)
Contains(t, mockT.errorString(), "<... truncated>")
}
}
Loading