fix: crash when resizing render window and at the same time creating textures in a background thread#2842
Merged
Eideren merged 2 commits intostride3d:masterfrom Aug 28, 2025
Merged
Conversation
…me creating textures in a background thread A relevant lock statement on the internal GraphicsDevice.Resources collection was missing.
Collaborator
|
Looks like there are other places in the source where |
Collaborator
Author
|
Ok can you point me to them? I remember I did a quick search and all the other places looked good to me. |
Collaborator
|
Entirely within this file actually: https://github.com/stride3d/stride/blob/master/sources/engine/Stride.Graphics/ResumeManager.cs |
Collaborator
Author
|
@Eideren Thanks, updated |
Collaborator
|
Thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
A relevant lock statement on the internal GraphicsDevice.Resources collection was missing.
Related Issue
Types of changes
Checklist