Conversation
| </PropertyGroup> | ||
|
|
||
| <PropertyGroup Condition="'$(StridePlatform)' == 'Linux'"> | ||
| <StrideGraphicsApis Condition="'$(StrideGraphicsApis)' == ''">OpenGL</StrideGraphicsApis> |
There was a problem hiding this comment.
This should not be removed and set to Vulkan instead
There was a problem hiding this comment.
I originally did it on purpose, because Linux now had only a single Graphics API, not multiple, so it was supposedly set by StrideGraphicsApi (without a s).
However I noticed some other issue with this system so currently reviewing the changes.
I might revert them for now.
| @@ -1,8 +1,5 @@ | |||
| <!-- Build file pre-included by all Stride projects --> | |||
| <Project xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <PropertyGroup Condition="'$(StridePlatform)' == 'Linux'"> | |||
|
Besides my few notes It looks great. I cant wait to see being merged😀 |
Ethereal77
left a comment
Ethereal77
left a comment
There was a problem hiding this comment.
Just left a few comments. Btw, now that OpenGL is gone, the GLSL-specific part of the shader compiler (that now is only for Vulkan) is inside a directory named OpenGL.
|
|
||
| public override void DeviceChanged(GraphicsDevice currentDevice, GraphicsDeviceInformation deviceInformation) | ||
| { | ||
| // TODO: Check when it needs to be disabled on iOS (OpenGL)? |
There was a problem hiding this comment.
This comment mentions iOS on a file named GamePlatformAndroid. Is this correct?
| // TODO: Remove when the Tiff format is supported on Android | ||
| sourceFormat == ImageFileType.Tiff), |
There was a problem hiding this comment.
This check is for TIFF format on Android, not only for OpenGL, is it?
There was a problem hiding this comment.
Good point.
I will just leave this special case removed and see when we get Android working again if it needs to be readded.
|
While I'm agree to The decision of getting rid off GL in desktop, I sugest to consider on keep OpenGL ES at least. Some devices such android phones, emulation consoles or even Raspberry pi are still using It. Thanks. |
4 participants
PR Details
Remove OpenGL.
git grepping "OpenGL", most references left are related to the shader converter (HLSL => GLSL) used by Vulkan.
TODO:
Types of changes
Checklist