Skip to content

Conversation

@NimaSarajpoor
Copy link
Collaborator

@NimaSarajpoor NimaSarajpoor commented Jan 7, 2025

See #1059

The functions with missing fastmath flags are:

  • core._get_array_ranges
  • core._get_ranges
  • core._merge_topk_PI
  • core._merge_topk_ρI
  • core._shift_insert_at_index
  • core._update_incremental_PI

@NimaSarajpoor NimaSarajpoor requested a review from seanlaw as a code owner January 7, 2025 21:52
@codecov
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 7.57576% with 61 lines in your changes missing coverage. Please review.

Project coverage is 96.97%. Comparing base (3165d1c) to head (de242d5).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
fastmath.py 0.00% 49 Missing ⚠️
stumpy/cache.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   97.33%   96.97%   -0.36%     
==========================================
  Files          89       90       +1     
  Lines       15027    15104      +77     
==========================================
+ Hits        14626    14647      +21     
- Misses        401      457      +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not look at the def check_fastmath function yet and I assume it is doing the right thing?

Copy link
Collaborator Author

@NimaSarajpoor NimaSarajpoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seanlaw
I tried to make some changes according to our recent discussion. I left some comments to bring your attention to a few things.

@NimaSarajpoor
Copy link
Collaborator Author

@seanlaw
Can you please do a final check and merge if there is no concern and all tests are passing?

@seanlaw
Copy link
Contributor

seanlaw commented Jan 12, 2025

@seanlaw Can you please do a final check and merge if there is no concern and all tests are passing?

Will do! Thanks for pulling this together

@seanlaw seanlaw merged commit 70e4e70 into stumpy-dev:main Jan 12, 2025
27 checks passed
@seanlaw
Copy link
Contributor

seanlaw commented Jan 12, 2025

Thanks @NimaSarajpoor. This has now been merged!

@NimaSarajpoor
Copy link
Collaborator Author

@seanlaw
Great! That was one good PR [for me]! Thanks for all of your inputs and suggestions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants