Skip to content

Fix #1059 missing fastmath #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Jan 12, 2025
Merged

Fix #1059 missing fastmath #1060

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
280eb9b
add function to check fastmath
NimaSarajpoor Jan 7, 2025
e9d1256
revise fastmath script and add support for reading arg from command line
NimaSarajpoor Jan 7, 2025
857c281
minor fixes
NimaSarajpoor Jan 7, 2025
df9840f
rename function to improve readability
NimaSarajpoor Jan 7, 2025
e4edee2
simplify code by passing boolean value
NimaSarajpoor Jan 7, 2025
9bf37f7
fix to catch njit functions with decorator
NimaSarajpoor Jan 8, 2025
a90c8d4
use regex to find njit functions
NimaSarajpoor Jan 8, 2025
b8ffac9
minor change
NimaSarajpoor Jan 8, 2025
ed6cef0
revise code to detect bare njit decorator
NimaSarajpoor Jan 9, 2025
799aceb
minor fix
NimaSarajpoor Jan 9, 2025
341e914
fix path
NimaSarajpoor Jan 9, 2025
9f84dd5
add missing fastmath
NimaSarajpoor Jan 9, 2025
f479dbe
revise fastmath flag
NimaSarajpoor Jan 9, 2025
d7d1a79
Improve ValueError msg
NimaSarajpoor Jan 11, 2025
b6adc93
fix format
NimaSarajpoor Jan 11, 2025
f497d44
enable function to accept path as input
NimaSarajpoor Jan 11, 2025
9fa7805
pass param via CLI, and some minor changes
NimaSarajpoor Jan 12, 2025
56fd344
adapt changes in test script
NimaSarajpoor Jan 12, 2025
3c5ba61
use type str for the param pkg_dir
NimaSarajpoor Jan 12, 2025
8e82765
minor changes
NimaSarajpoor Jan 12, 2025
de242d5
Revised string concatenation in error message
NimaSarajpoor Jan 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions stumpy/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2347,6 +2347,7 @@ def _count_diagonal_ndist(diags, m, n_A, n_B):

@njit(
# "i8[:, :](i8[:], i8, b1)"
fastmath={"nsz", "arcp", "contract", "afn", "reassoc"}
)
def _get_array_ranges(a, n_chunks, truncate):
"""
Expand Down Expand Up @@ -2395,6 +2396,7 @@ def _get_array_ranges(a, n_chunks, truncate):

@njit(
# "i8[:, :](i8, i8, b1)"
fastmath=True
)
def _get_ranges(size, n_chunks, truncate):
"""
Expand Down Expand Up @@ -3247,7 +3249,7 @@ def _select_P_ABBA_value(P_ABBA, k, custom_func=None):
return MPdist


@njit()
@njit(fastmath={"nsz", "arcp", "contract", "afn", "reassoc"})
def _merge_topk_PI(PA, PB, IA, IB):
"""
Merge two top-k matrix profiles `PA` and `PB`, and update `PA` (in place).
Expand Down Expand Up @@ -3320,7 +3322,7 @@ def _merge_topk_PI(PA, PB, IA, IB):
IA[i] = tmp_I


@njit()
@njit(fastmath={"nsz", "arcp", "contract", "afn", "reassoc"})
def _merge_topk_ρI(ρA, ρB, IA, IB):
"""
Merge two top-k pearson profiles `ρA` and `ρB`, and update `ρA` (in place).
Expand Down Expand Up @@ -3394,7 +3396,7 @@ def _merge_topk_ρI(ρA, ρB, IA, IB):
IA[i] = tmp_I


@njit()
@njit(fastmath={"nsz", "arcp", "contract", "afn", "reassoc"})
def _shift_insert_at_index(a, idx, v, shift="right"):
"""
If `shift=right` (default), all elements in `a[idx:]` are shifted to the right by
Expand Down Expand Up @@ -4370,7 +4372,7 @@ def get_ray_nworkers(ray_client):
return int(ray_client.cluster_resources().get("CPU"))


@njit
@njit(fastmath={"nsz", "arcp", "contract", "afn", "reassoc"})
def _update_incremental_PI(D, P, I, excl_zone, n_appended=0):
"""
Given the 1D array distance profile, `D`, of the last subsequence of T,
Expand Down
Loading