Skip to content

Comments

Modify the webhook bot to add 'ready-to-test' label for Dependabot PRs#240

Merged
tpantelis merged 2 commits intosubmariner-io:develfrom
tpantelis:add_rtt_in_bot
Feb 4, 2026
Merged

Modify the webhook bot to add 'ready-to-test' label for Dependabot PRs#240
tpantelis merged 2 commits intosubmariner-io:develfrom
tpantelis:add_rtt_in_bot

Conversation

@tpantelis
Copy link
Contributor

@tpantelis tpantelis commented Feb 1, 2026

...and remove it from the Coderabbit trigger GH action. The latter does not trigger the additional E2E jobs when the label is added. This is a security feature in GitHub whereby it does not trigger subsequent workflow runs when a GH Action uses the default GITHUB_TOKEN. The action would have to use a Personal Access or GitHub App Token. But rather than doing that, we can enhance the existing webhook bot to do this since it already has an appropriate token and already adds the 'ready-to-test' label when approvals are met.

Summary by CodeRabbit

  • New Features

    • Dependabot pull requests are now automatically marked with an approved label when opened.
  • Chores

    • Removed automatic label assignment from the auto-merge workflow, streamlining the process.

✏️ Tip: You can customize this high-level summary in your review settings.

...and remove it from the Coderabbit trigger GH action. The latter does
not trigger the additional E2E jobs when the label is added. This is a
security feature in GitHub whereby it does not trigger subsequent
workflow runs when a GH Action uses the default GITHUB_TOKEN. The
action would have to use a Personal Access or GitHub App Token. But
rather than doing that, we can enhance the existing webhook bot to do
this since it already has an appropriate token and already adds the
'ready-to-test' label when approvals are met.

Signed-off-by: Tom Pantelis <tompantelis@gmail.com>
@tpantelis tpantelis self-assigned this Feb 1, 2026
@submariner-bot
Copy link

🤖 Created branch: z_pr240/tpantelis/add_rtt_in_bot

@coderabbitai
Copy link

coderabbitai bot commented Feb 1, 2026

Walkthrough

This pull request removes the "ready-to-test" label application from the CodeRabbit trigger workflow and introduces automatic label application for Dependabot-opened pull requests in the handler, streamlining the labeling behavior for bot-initiated PRs.

Changes

Cohort / File(s) Summary
Workflow Label Removal
.github/workflows/coderabbit-trigger.yml
Removed the block that adds the "ready-to-test" label after enabling auto-merge, simplifying the control flow to only enable auto-merge without subsequent label mutations.
Dependabot PR Auto-Labeling
pkg/handler/pullrequest/handler.go
Added isDependabotPR() helper to detect Dependabot PRs by author variants, and introduced conditional logic in openOrSync() to automatically apply the approved label when a Dependabot PR is opened (if LabelApproved config exists), with error logging.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Suggested reviewers

  • Oats87
  • sridhargaddam
  • skitt
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: modifying the webhook bot to add 'ready-to-test' label for Dependabot PRs, which is the primary objective documented in the PR.
Actionable Comments Resolved ✅ Passed No unresolved actionable comments found. Pre-existing TODO comments are unrelated to this PR. Implementation is complete and focused with proper label application.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tpantelis tpantelis merged commit d6b1b8e into submariner-io:devel Feb 4, 2026
8 checks passed
@submariner-bot
Copy link

🤖 Closed branches: [z_pr240/tpantelis/add_rtt_in_bot]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants