feat(isthmus): add support for scalar subqueries#353
Merged
vbarua merged 1 commit intosubstrait-io:mainfrom Mar 26, 2025
Merged
feat(isthmus): add support for scalar subqueries#353vbarua merged 1 commit intosubstrait-io:mainfrom
vbarua merged 1 commit intosubstrait-io:mainfrom
Conversation
vbarua
reviewed
Mar 26, 2025
Member
vbarua
left a comment
There was a problem hiding this comment.
The conversion code looks good overall. I left some comments that will hopefully simplify the testing of this a little bit.
isthmus/src/test/java/io/substrait/isthmus/SubstraitExpressionConverterTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/SubstraitExpressionConverterTest.java
Outdated
Show resolved
Hide resolved
isthmus/src/test/java/io/substrait/isthmus/SubstraitExpressionConverterTest.java
Outdated
Show resolved
Hide resolved
966340a to
dfde97a
Compare
vbarua
reviewed
Mar 26, 2025
isthmus/src/main/java/io/substrait/isthmus/SubstraitToCalcite.java
Outdated
Show resolved
Hide resolved
vbarua
approved these changes
Mar 26, 2025
Signed-off-by: Niels Pardon <par@zurich.ibm.com>
dfde97a to
fac90ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Substrait to Calcite mappings to not support scalar subqueries like the follow SQL example:
This PR adds support for mapping scalar subqueries from Substrait into Calcite and adds a test case showing that it works now.
Additionally:
RelCreatorto be created with a list of CREATE SQL statements to initialize the schema of theRelBuilderRelCreatorto extendSqlConverterBaseso that we can reuse theregisterCreateTables()methodSubstraitExpressionConverterTestit gets theExpressionRexConverterfromSubstraitRelNodeConverterin order to make sure theExpressionRexConverteris properly set up to parse sub queries usingSubstraitRelNodeConverter