Skip to content

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Oct 23, 2025

Purpose

Fix an accessibility issue raised by Axe: the logo image had an alt attribute, which was redundant with the surrounding link’s aria-label="Back to homepage".

Proposal

  • Set alt="" on the logo image to avoid redundancy
  • Ensure a11y remains covered by the parent link’s aria-label

@Ovgodd Ovgodd self-assigned this Oct 23, 2025
@Ovgodd Ovgodd requested a review from AntoLC October 23, 2025 07:22
@Ovgodd Ovgodd force-pushed the fix/minor-axe-alt-error branch from 41e9615 to 7995738 Compare October 23, 2025 07:23
@Ovgodd Ovgodd marked this pull request as ready for review October 23, 2025 07:24
@github-actions
Copy link

github-actions bot commented Oct 23, 2025

Size Change: +14 B (0%)

Total Size: 3.68 MB

Filename Size Change
apps/impress/out/_next/static/c6670110/_buildManifest.js 0 B -878 B (removed) 🏆
apps/impress/out/_next/static/1eb072fa/_buildManifest.js 879 B +879 B (new file) 🆕

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/minor-axe-alt-error branch 2 times, most recently from 053d60c to fca7631 Compare October 23, 2025 09:07
logo: {
src: '/assets/logo-gouv.svg',
width: '220px',
alt: 'Gouvernement Logo',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so it means that we cannot override the alt anymore, we should modify the types so and remove the alt prop I suppose:

Same here, we should remove the alt part:

@Ovgodd Ovgodd requested a review from AntoLC October 23, 2025 11:14
@Ovgodd Ovgodd force-pushed the fix/minor-axe-alt-error branch from 9db14b0 to 4ed2416 Compare October 23, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants