Skip to content

✨(frontend) remove empty alt on logo due to Axe a11y error #1516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

✨(frontend) remove empty alt on logo due to Axe a11y error #1516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f7169b
✨(frontend) set empty alt on logo due to Axe a11y error
Ovgodd Oct 23, 2025
4ed2416
fixup! ✨(frontend) set empty alt on logo due to Axe a11y error
Ovgodd Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ and this project adheres to
- 🐛(frontend) fix duplicate document entries in grid #1479
- 🐛(frontend) show full nested doc names with ajustable bar #1456
- 🐛(backend) fix trashbin list
- ♿(frontend) improve accessibility:
- ♿(frontend) remove empty alt on logo due to Axe a11y error #1516

## [3.8.2] - 2025-10-17

Expand Down
9 changes: 6 additions & 3 deletions src/frontend/apps/e2e/__tests__/app-impress/header.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ test.describe('Header: Override configuration', () => {
logo: {
src: '/assets/logo-gouv.svg',
width: '220px',
alt: 'Gouvernement Logo',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so it means that we cannot override the alt anymore, we should modify the types so and remove the alt prop I suppose:

docs/src/frontend/apps/impress/src/features/header/types.ts

Line 6 in 246e0a9

alt?: string;

Same here, we should remove the alt part:

docs/src/helm/env.d/dev/configuration/theme/demo.json

Line 141 in 246e0a9

"alt": "Notes"

alt: '',
},
},
},
Expand All @@ -168,8 +168,11 @@ test.describe('Header: Override configuration', () => {
await page.goto('/');
const header = page.locator('header').first();

await expect(header.getByAltText('Gouvernement Logo')).toBeVisible();
const logoImage = header.getByTestId('header-icon-docs');
await expect(logoImage).toBeVisible();

await expect(header.getByAltText('Docs')).toBeHidden();
await expect(logoImage).not.toHaveAttribute('src', '/assets/icon-docs.svg');
await expect(logoImage).toHaveAttribute('src', '/assets/logo-gouv.svg');
await expect(logoImage).toHaveAttribute('alt', '');
});
});
2 changes: 1 addition & 1 deletion src/frontend/apps/impress/src/features/header/components/Header.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const Header = () => {
className="c__image-system-filter"
data-testid="header-icon-docs"
src={logo?.src || '/assets/icon-docs.svg'}
alt={logo?.alt || t('Docs')}
alt=""
width={0}
height={0}
style={{
Expand Down
1 change: 0 additions & 1 deletion src/frontend/apps/impress/src/features/header/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@ export interface HeaderType {
src?: string;
width?: string;
height?: string;
alt?: string;
};
}
3 changes: 1 addition & 2 deletions src/helm/env.d/dev/configuration/theme/demo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@
"header": {
"logo": {
"src": "/assets/icon-docs.svg",
"width": "32px",
"alt": "Notes"
"width": "32px"
}
}
}
Loading