Closed
Conversation
ListBuilder/DynamicListBuilder.php
Outdated
|
|
||
| return $this->downloadUrl; | ||
| return $this->router->generate('sulu_media.redirect', [ | ||
| 'id' => $value, |
Member
There was a problem hiding this comment.
keep the caching mechanic with this->downloadUrl calling router->generate is a heavy process sadly which should be avoid in this kind of loops. So we added this mechanic to only generate once a wildcard urls with {id} and use str_replace
martinlagler
force-pushed
the
bugfix/media-url
branch
from
ad2f834 to
dcf2027
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Use media redirect route to fix media url in data tab.