Skip to content

Conversation

@DanRyanIrish
Copy link
Member

@DanRyanIrish DanRyanIrish commented Aug 15, 2025

To Do

@DanRyanIrish DanRyanIrish added this to the 2.4.0 milestone Aug 15, 2025
Copy link
Member

@wtbarnes wtbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to wrap my head around what's happening here and I don't see anything obviously problematic (though I don't know much about NDData either). My one suggestion would be adding a test that constructs an NDData from a dask array (I think this is possible??) and then apply a these operations (at least add and mul) to that object and ensure that the laziness is preserved in these new codepaths.

@DanRyanIrish
Copy link
Member Author

@wtbarnes: Do these tests satisfy your comment?

@DanRyanIrish
Copy link
Member Author

@Cadair @wtbarnes: Docs on Arithmetic operations are now included in this PR. Please let me know if you have comments. If not, I'd appreciate an approval :)

@DanRyanIrish DanRyanIrish marked this pull request as ready for review October 9, 2025 12:17
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to decide on what we are doing with the open docs comments.

@Cadair Cadair force-pushed the nddataArithmetic2 branch from 161b3b7 to 1ce2c1d Compare December 3, 2025 15:02
@Cadair Cadair merged commit 55e7ea0 into sunpy:main Dec 3, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants