-
-
Notifications
You must be signed in to change notification settings - Fork 54
Support Subtract and Division of NDCube by NDData #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
wtbarnes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tried to wrap my head around what's happening here and I don't see anything obviously problematic (though I don't know much about NDData either). My one suggestion would be adding a test that constructs an NDData from a dask array (I think this is possible??) and then apply a these operations (at least add and mul) to that object and ensure that the laziness is preserved in these new codepaths.
…preserve dask laziness.
|
@wtbarnes: Do these tests satisfy your comment? |
0c2e688 to
1bcd97f
Compare
f90bf15 to
9f9805f
Compare
…to nddataArithmetic2
Co-authored-by: Stuart Mumford <[email protected]>
Cadair
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to decide on what we are doing with the open docs comments.
161b3b7 to
1ce2c1d
Compare
To Do