Add NDCube method to convert to NDData instance. #887
Conversation
Allow attributes to be changed via kwargs.
|
@Cadair: I found time to PR this. Whatever we agree on the call signature, I think this captures the core of the implementation. |
|
So @Cadair, what's your call signature decorator idea? |
There was a problem hiding this comment.
Once #880 is merged, a link in the docstring of this function to the narrative docs in that PR would be helpful in explaining the usefulness of this function as it is not immediately obvious how one would make use of this. This of course could be done in a subsequent PR as that PR depends on this one.
Sounds good. I can include this in #887 |
DanRyanIrish
force-pushed
the
to_nddata
branch
from
b2dca8d to
e59127b
Compare
…eral. And docstring fix.
DanRyanIrish
force-pushed
the
to_nddata
branch
from
e59127b to
d46bcaa
Compare
| if extra_coords is COPY: | ||
| extra_coords = copy.copy(self._extra_coords) | ||
| extra_coords._ndcube = new_nddata | ||
| new_nddata._extra_coords = extra_coords | ||
| if global_coords is COPY: | ||
| new_nddata._global_coords = copy.copy(self._global_coords) |
There was a problem hiding this comment.
We should really add these as kwargs to ndcube's constructor lol.
There was a problem hiding this comment.
I agree! Let's keep that as separate to this PR though.
| all_kwargs = {key.strip("_"): value for key, value in self.__dict__.items()} | ||
| all_kwargs.update(user_kwargs) | ||
| # Inspect call signature of new_nddata class and | ||
| # remove unsupported items from new_kwargs. | ||
| all_kwargs = {key: value for key, value in all_kwargs.items() | ||
| if key in inspect.signature(nddata_type).parameters.keys()} |
There was a problem hiding this comment.
I am not a fan of extracting all the attributes like this, it feels exceptionally brittle.
Do we really need to do this? Can't we just say if you need to copy custom attributes of a non-NDData class you need to specify them as explicit keyword arguments? Then this dictionary comprehension is just for the things where the kwarg value is COPY.
There was a problem hiding this comment.
Unless there's a better way to filter the kwargs by the call signature of nddata_type, then yes, we need this.
There was a problem hiding this comment.
That wasn't the part I was objecting to. I'll open a followup PR when I get the chance.
3 participants
PR Description
This PR introduces a new method
NDCube.to_nddata, which allows for anNDCubeto be converted to anNDData(or subclass of same) instance. The motivating use case is to enable users to easily drop coordinate-awareness from their data and thereby perform arithmetic operations with NDCubes.