fix: start tracing only if enabled and endpoint exists

[ferhatelmas]

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

If tracing is enabled but endpoint is missing, instrumentation will start but won't export anything. Pure overhead.

What is the new behavior?

Start tracing only if enabled and exporter endpoint is given.

Additional context

None

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Cache: Disabled due to Reviews > Disable Cache setting

Disabled knowledge base sources:

• Linear integration is disabled

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 2e9c044 and 7b7fc02.

📒 Files selected for processing (1)

• src/internal/monitoring/otel-tracing.ts

---

📝 Walkthrough

Summary by CodeRabbit

• Bug Fixes
  • Tracing now initializes only when fully configured, preventing partial startup when exporter is missing.
  • Added warnings when tracing is enabled but no exporter/endpoint is configured.
  • Startup reliability improved by ensuring tracing processors and SDK start only when all required tracing components are present.

Walkthrough

The change tightens OpenTelemetry tracing initialization: span processors are only created when a trace exporter exists (BatchSpanProcessor is instantiated inline alongside TenantSpanProcessor), and the SDK is started only if tracing is enabled, a trace exporter is configured, and at least one span processor is present. If tracing is enabled but no OTLP endpoint/trace exporter is configured, a warning is logged and SDK startup is skipped.

Sequence Diagram(s)

sequenceDiagram
    participant Config as Tracing Config
    participant Logger as Logger
    participant Exporter as TraceExporter
    participant Processors as SpanProcessors
    participant SDK as Tracing SDK

    Config->>Logger: Read tracingEnabled
    alt tracingEnabled = false
        Config->>Logger: Do not initialize tracing
    else tracingEnabled = true
        Config->>Exporter: Check for traceExporter (OTLP endpoint)
        alt traceExporter exists
            Exporter->>Processors: Create TenantSpanProcessor
            Exporter->>Processors: Create BatchSpanProcessor (inline)
            Processors->>SDK: Provide configured span processors
            SDK->>SDK: Start SDK
            SDK-->>Logger: Tracing started
        else no traceExporter
            Logger-->>Config: Log warning (tracing enabled but no exporter)
            Config->>SDK: Skip SDK startup
        end
    end

Loading

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}