Skip to content

fix: start tracing only if enabled and endpoint exists #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ferhatelmas merged 1 commit into from
Mar 3, 2026
+11 −9
Merged

fix: start tracing only if enabled and endpoint exists #884

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions src/internal/monitoring/otel-tracing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,22 @@ if (tracingEnabled && endpoint) {
})
}

// Create a BatchSpanProcessor using the trace exporter
const batchProcessor = traceExporter ? new BatchSpanProcessor(traceExporter) : undefined

const spanProcessors: SpanProcessor[] = []

if (tracingEnabled) {
if (tracingEnabled && traceExporter) {
spanProcessors.push(new TenantSpanProcessor())
spanProcessors.push(new BatchSpanProcessor(traceExporter))
} else if (tracingEnabled) {
logSchema.warning(
logger,
'[Otel] TRACING_ENABLED=true but no OTLP trace endpoint configured; skipping tracing SDK startup',
{
type: 'otel',
}
)
}

if (batchProcessor) {
spanProcessors.push(batchProcessor)
}

if (tracingEnabled && spanProcessors.length > 0) {
if (tracingEnabled && traceExporter && spanProcessors.length > 0) {
// Configure the OpenTelemetry Node SDK
const sdk = new NodeSDK({
resource: resourceFromAttributes({
Expand Down