refactor: Simplify httpClient conditional logic using ternary operator #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixkamau
changed the title
Pull Request Test Coverage Report for Build 16415550728Details
💛 - Coveralls |
richard457
reviewed
Jul 21, 2025
| // } else { | ||
| // streamedResponse = await request.send(); | ||
| // } | ||
| streamedResponse = httpClient != null |
There was a problem hiding this comment.
Why this change, is there a special reason? what is wrong with old implementation?
There was a problem hiding this comment.
The logic is self contained in one expression
There was a problem hiding this comment.
but what are the benefit or a bug does this fix?
There was a problem hiding this comment.
just refactoring
|
I prefer the current style and it's easier to extend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor
What is the current behavior?
The _handleRequest method uses an if-else statement to conditionally assign the streamedResponse variable based on whether httpClient is null or not. The logic spans multiple lines and uses a commented-out block.
What is the new behavior?
The same conditional logic is now implemented using a ternary operator, making the code more concise and readable