Skip to content

refactor: Simplify httpClient conditional logic using ternary operator #1204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

refactor: Simplify httpClient conditional logic using ternary operator #1204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b36c5b8
refactor: remove unnecessary parentheses in fromJson constructors
felixkamau Jul 10, 2025
ee63fc9
refactor: Simplify httpClient conditional logic using ternary operator
felixkamau Jul 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions packages/storage_client/lib/src/fetch.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,11 +82,15 @@ class Fetch {

_log.finest('Request: $method $url $headers');
final http.StreamedResponse streamedResponse;
if (httpClient != null) {
streamedResponse = await httpClient!.send(request);
} else {
streamedResponse = await request.send();
}
// if (httpClient != null) {
// streamedResponse = await httpClient!.send(request);
// } else {
// streamedResponse = await request.send();
// }
streamedResponse = httpClient != null
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change, is there a special reason? what is wrong with old implementation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is self contained in one expression

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what are the benefit or a bug does this fix?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just refactoring

? await httpClient!.send(request)
: await request.send();

return _handleResponse(streamedResponse, options);
}

Expand Down
2 changes: 1 addition & 1 deletion packages/storage_client/lib/src/types.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ class Bucket {
});

Bucket.fromJson(Map<String, dynamic> json)
: id = (json)['id'] as String,
: id = json['id'] as String,
name = json['name'] as String,
owner = json['owner'] as String,
createdAt = json['created_at'] as String,
Expand Down
Loading