Skip to content

Conversation

@KiRura
Copy link

@KiRura KiRura commented Jan 8, 2026

https://svelte.jp/docs/cli/eslint states:

What you get
updated .vscode/settings.json

However, when settings.json already exists and eslint.validate is undefined, the settings are not updated, preventing the ESLint extension from linting .svelte files.

@changeset-bot
Copy link

changeset-bot bot commented Jan 8, 2026

🦋 Changeset detected

Latest commit: 584408b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
sv Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@jycouet jycouet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking at this.
Could you add a changelog? (pnpm changeset and looking at others in CHANGELOG.md, find something that fit :) )

@jycouet
Copy link
Contributor

jycouet commented Jan 8, 2026

Actually, according to #846 we don't need this eslint.validate anymore!

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 9, 2026

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@871
npx https://pkg.pr.new/sveltejs/cli/sv@871

commit: 584408b

@jycouet
Copy link
Contributor

jycouet commented Jan 9, 2026

Sorry, I jeopardize your PR @KiRura ! Do you still agree?

Like this it would:

@hyunbinseo could you have a look as well ?
@manuel3108 could you check as well api / naming ?

Thx :)

@KiRura
Copy link
Author

KiRura commented Jan 9, 2026

Yes, that's fine with me!
I wasn't aware that files.associations could work instead of eslint.validate. I apologize for my lack of knowledge.

@KiRura KiRura changed the title fix: ensure eslint.validate is created when missing feat(eslint): with [email protected] ESLint extension, we don't need to set eslint.validate anymore Jan 9, 2026
@jycouet jycouet changed the title feat(eslint): with [email protected] ESLint extension, we don't need to set eslint.validate anymore feat(eslint): remove vscode eslint.validate Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants