-
-
Notifications
You must be signed in to change notification settings - Fork 75
feat(eslint): remove vscode eslint.validate
#871
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 584408b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jycouet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for looking at this.
Could you add a changelog? (pnpm changeset and looking at others in CHANGELOG.md, find something that fit :) )
|
Actually, according to #846 we don't need this |
commit: |
|
Sorry, I jeopardize your PR @KiRura ! Do you still agree? Like this it would:
@hyunbinseo could you have a look as well ? Thx :) |
|
Yes, that's fine with me! |
[email protected] ESLint extension, we don't need to set eslint.validate anymore
[email protected] ESLint extension, we don't need to set eslint.validate anymoreeslint.validate
https://svelte.jp/docs/cli/eslint states:
However, when settings.json already exists and
eslint.validateis undefined, the settings are not updated, preventing the ESLint extension from linting.sveltefiles.