Skip to content

feat(eslint): remove vscode eslint.validate #871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jycouet merged 6 commits into from
Jan 18, 2026
Merged

feat(eslint): remove vscode eslint.validate #871

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
835d9f9
fix: ensure eslint.validate is created when missing
KiRura Jan 8, 2026
eb98309
fix: add javascript and typescript to eslint.validate
KiRura Jan 8, 2026
57cbbc4
what about json array upsert
jycouet Jan 8, 2026
92a1038
remove `eslint.validate` at all
jycouet Jan 8, 2026
818ca2b
and update snap
jycouet Jan 8, 2026
584408b
internal refacto
jycouet Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/sv/lib/addons/eslint/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,13 @@ export default defineAddon({
if (!content) return content;

const { data, generateCode } = parseJson(content);
const validate: string[] | undefined = data['eslint.validate'];
if (validate && !validate.includes('svelte')) {
const validate: string[] = data['eslint.validate'] ?? ['typescript', 'javascript', 'svelte'];

if (!validate.includes('svelte')) {
validate.push('svelte');
}

data['eslint.validate'] = validate;
return generateCode();
});

Expand Down