Skip to content

feat(prefer-svelte-reactivity): ignoring encapsulated local variables by default #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

marekdedic
Copy link
Contributor

@marekdedic marekdedic commented Aug 6, 2025

Fixes #1271

Copy link

changeset-bot bot commented Aug 6, 2025

🦋 Changeset detected

Latest commit: 3466ad0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-svelte Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 6, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/eslint-plugin-svelte@3466ad0

Published Instant Preview Packages:

View Commit

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch 27 times, most recently from e353727 to be6878b Compare August 6, 2025 19:19
@marekdedic marekdedic marked this pull request as ready for review August 6, 2025 19:21
@marekdedic
Copy link
Contributor Author

Hey @ota-meshi @baseballyama, sorry to ping you, but could you please help me with the CI? I have no idea why it fails and how to debug it :(

@marekdedic
Copy link
Contributor Author

Also, I'll be away for the next 2 weeks, so I won't be able to respond or fix anything. But I've enabled editing by maintainers, so if you want, feel free to edit the PR and merge it while I'm away :)

@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch 8 times, most recently from 47ec4f9 to 52ef1f0 Compare August 8, 2025 08:31
@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch from 52ef1f0 to 9354900 Compare August 8, 2025 09:38
@marekdedic marekdedic force-pushed the prefere-svelte-reactivity-ignore-encapsulated-local-variables branch from 9354900 to d853d1b Compare August 8, 2025 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

svelte/prefer-svelte-reactivity triggers inside non-reactive functions (e.g., URL, Date, Set usage)
1 participant