Skip to content

Conversation

@paoloricciuti
Copy link
Member

@paoloricciuti paoloricciuti commented Oct 4, 2024

Companion PR for sveltejs/svelte#13504

if we decide to merge we can pass the filename to allow the migration script to migrate svelte:self which is deprecated in svelte 5. I've tested it locally and it seems to work fine but i'm not sure if i should add some proper test (and where.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: 8cf432b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte-migrate Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benmccann benmccann added pkg:svelte-migrate Issues related to the svelte-migrate package svelte 5 labels Oct 5, 2024
@dummdidumm dummdidumm merged commit 66dff3e into sveltejs:main Oct 5, 2024
9 of 10 checks passed
This was referenced Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:svelte-migrate Issues related to the svelte-migrate package svelte 5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants