Skip to content

feat: pass filename to migrate #12749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 5, 2024
Merged

feat: pass filename to migrate #12749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a0c57c2
feat: pass filename to `migrate`
paoloricciuti Oct 4, 2024
a259bac
chore: changeset
paoloricciuti Oct 4, 2024
8cf432b
chore: adapt with new changes from PR
paoloricciuti Oct 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dry-feet-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte-migrate': minor
---

feat: pass filename to `migrate` to allow for `svelte:self` migration
2 changes: 1 addition & 1 deletion packages/migrate/migrations/svelte-5/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ export async function migrate() {
if (extensions.some((ext) => file.endsWith(ext))) {
if (svelte_extensions.some((ext) => file.endsWith(ext))) {
update_svelte_file(file, transform_module_code, (code) =>
transform_svelte_code(code, migrate)
transform_svelte_code(code, migrate, { filename: file })
);
} else {
update_js_file(file, transform_module_code);
Expand Down
7 changes: 4 additions & 3 deletions packages/migrate/migrations/svelte-5/migrate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,11 @@ export function transform_module_code(code) {

/**
* @param {string} code
* @param {(source: code) => { code: string }} transform_code
* @param {(source: string, options: { filename?: string }) => { code: string }} transform_code
* @param {{ filename?: string }} options
*/
export function transform_svelte_code(code, transform_code) {
return transform_code(code).code;
export function transform_svelte_code(code, transform_code, options) {
return transform_code(code, options).code;
}

/**
Expand Down
Loading