Skip to content

fix: set cache header for non-immutable build assets #14483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+12 −6
Open

fix: set cache header for non-immutable build assets #14483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
16b2698
Set cache-control header for non-immutable assets
TorstenDittmann Sep 19, 2025
7462272
Fix cache-control headers for app path files only
TorstenDittmann Sep 19, 2025
d82fcc6
Set no-cache header for non-immutable assets in node adapter
TorstenDittmann Sep 19, 2025
46c5757
Update non-static asset cache-control header
TorstenDittmann Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tricky-pillows-remain.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/adapter-node': patch
---

fix: set no-cache cache-control header for non-immutable assets
13 changes: 7 additions & 6 deletions packages/adapter-node/src/handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,13 @@ function serve(path, client = false) {
brotli: true,
setHeaders: client
? (res, pathname) => {
// only apply to build directory, not e.g. version.json
if (
pathname.startsWith(`/${manifest.appPath}/immutable/`) &&
res.statusCode === 200
) {
res.setHeader('cache-control', 'public,max-age=31536000,immutable');
if (res.statusCode === 200 && pathname.startsWith(`/${manifest.appPath}/`)) {
if (pathname.startsWith(`/${manifest.appPath}/immutable/`)) {
// only apply to build directory, not e.g. version.json
res.setHeader('cache-control', 'public,max-age=31536000,immutable');
} else {
res.setHeader('cache-control', 'public,max-age=0,must-revalidate');
}
}
}
: undefined
Expand Down
Loading