giant image #375
Merged
giant image #375
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
okay looks like i need to specify different widths |
… read me the docs
|
ah it worked! |
benmccann
reviewed
Oct 13, 2024
| <figure> | ||
| <enhanced:img | ||
| src="./summit.png" | ||
| src="./summit.png?w=800;1200;2000;2800;4400" |
There was a problem hiding this comment.
I'd forgotten too, but the docs say to use sizes instead: https://kit.svelte.dev/docs/images#sveltejs-enhanced-img-srcset-and-sizes
There was a problem hiding this comment.
I think it's fine to just specify the width if it basically fills the screen (which it does up until the point that it wouldn't make any difference) — IIUC sizes is necessary if you know it'll be x pixels wide when the screen is y pixels wide, but it's a lot more finicky and brittle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i don't honestly recall what enhanced-image does in this scenario but i'm hoping it will generate lower resolution versions for smaller screens