Skip to content

giant image #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 13, 2024
Merged

giant image #375

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73bd9b6
giant image
Rich-Harris Oct 13, 2024
342a1c5
see if this does anything. otherwise i am going to have to ask ben to…
Rich-Harris Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/svelte.dev/src/routes/_home/Community.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<figure>
<enhanced:img
src="./summit.png"
src="./summit.png?w=800;1200;2000;2800;4400"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten too, but the docs say to use sizes instead: https://kit.svelte.dev/docs/images#sveltejs-enhanced-img-srcset-and-sizes

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine to just specify the width if it basically fills the screen (which it does up until the point that it wouldn't make any difference) — IIUC sizes is necessary if you know it'll be x pixels wide when the screen is y pixels wide, but it's a lot more finicky and brittle

alt="Photos by Marcel Cutts from the 2022 Svelte Summit in Stockholm"
/>
<figcaption>Photos by <a href="https://x.com/marcelcutts">Marcel Cutts</a></figcaption>
Expand Down
Binary file modified apps/svelte.dev/src/routes/_home/summit.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading