feat: legacy notes + checkbox #80
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This adds a note variant, which can be enabled using !LEGACY as the first text. It adds a blockquote using the "deprecated API" look. Additionally, a checkbox is added to the bottom (where the TS toggle was previously) to optionally disable those contents. The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.
dummdidumm
force-pushed
the
legacy-notes
branch
from
160b6c2 to
3d8c7b1
Compare
dummdidumm
added a commit
that referenced
this pull request
Sep 12, 2024
This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80 The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.
Merged
|
closing in favour of #81 |
Rich-Harris
added a commit
that referenced
this pull request
Sep 24, 2024
* feat: legacy details This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80 The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like. * fix position when toggling other elements * prevent flash-of-unopened-content * tweaks * tweak * old habits die hard * add show all/hide all text * prettier --------- Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a note variant, which can be enabled using !LEGACY as the first text. It adds a blockquote using the "deprecated API" look. Additionally, a checkbox is added to the bottom (where the TS toggle was previously) to optionally disable those contents.
The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.