Skip to content

Conversation

dummdidumm
Copy link
Member

This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80

The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.

This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80

The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.
Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
omnisite ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 7:04pm

@benmccann
Copy link
Member

I wonder if people will realize that collapsing one of the highlight sections will collapse them all. I think I'd just scroll past it and not collapse it because I wouldn't care about saving 100 pixels of space. If I knew it would close all of them I would certainly do that, but I wonder if we can make it more discoverable somehow

I wonder if instead of the triangle in the top left having text in the top right that says "hide legacy docs" or something might be a bit clearer?

@Rich-Harris
Copy link
Member

nice idea. done.

Styling-wise I think there's more we can do, but I want to tie that work into some other stuff I have in my head (will try and put an issue together shortly)

@Rich-Harris Rich-Harris merged commit 41c3d41 into main Sep 24, 2024
3 checks passed
@Rich-Harris Rich-Harris deleted the legacy-details branch September 24, 2024 19:05
@benmccann
Copy link
Member

Perhaps something for the issue: I was going to suggest dropping the bold font-weight from "show all"/"hide all". Here's a screenshot

Screenshot from 2024-09-24 12-05-23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants