-
-
Notifications
You must be signed in to change notification settings - Fork 191
feat: legacy details #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80 The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I wonder if people will realize that collapsing one of the highlight sections will collapse them all. I think I'd just scroll past it and not collapse it because I wouldn't care about saving 100 pixels of space. If I knew it would close all of them I would certainly do that, but I wonder if we can make it more discoverable somehow I wonder if instead of the triangle in the top left having text in the top right that says "hide legacy docs" or something might be a bit clearer? |
nice idea. done. Styling-wise I think there's more we can do, but I want to tie that work into some other stuff I have in my head (will try and put an issue together shortly) |
This adds a details blocks for legacy mode. If one is toggled, all are toggled. Alternative to #80
The idea is to add legacy syntax inline into the documentation at the appropriate places using these notes, and devs can hide those when unchecking the checkbox. The "Reactivity Fundamentals" page shows how this would look like.