Skip to content

fix: reset dependency read versions after reaction execution #14964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rich-Harris merged 7 commits into from
Jan 9, 2025
Merged

fix: reset dependency read versions after reaction execution #14964

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
387aa46
fix: reset dependency read versions after reaction execution
trueadm Jan 9, 2025
b6669fa
fix: reset dependency read versions after reaction execution
trueadm Jan 9, 2025
0168c34
fix: reset dependency read versions after reaction execution
trueadm Jan 9, 2025
d172aac
fix: reset dependency read versions after reaction execution
trueadm Jan 9, 2025
3e70c43
fix: reset dependency read versions after reaction execution
trueadm Jan 9, 2025
b2bf429
chore: add test
paoloricciuti Jan 9, 2025
b428f01
changeset
Rich-Harris Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/svelte/src/internal/client/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -424,10 +424,13 @@ export function update_reaction(reaction) {
reaction.deps = deps = new_deps;
}

if (!skip_reaction) {
for (i = skipped_deps; i < deps.length; i++) {
(deps[i].reactions ??= []).push(reaction);
for (i = skipped_deps; i < deps.length; i++) {
var dep = deps[i];
if (!skip_reaction) {
(dep.reactions ??= []).push(reaction);
}
// Reset read version back to 0
dep.rv = 0;
}
} else if (deps !== null && skipped_deps < deps.length) {
remove_reactions(reaction, skipped_deps);
Expand Down
Loading