Skip to content

[windows] move windows-llvm-lit-test-overrides.txt to the llvm-project repository #11143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

charles-zablit
Copy link

@charles-zablit charles-zablit commented Aug 7, 2025

This patch moves the file windows-llvm-lit-test-overrides.txt from swiftlang/swift to swiftlang/llvm-project.

As it controls the failing and skipped tests of LLVM, this will make it easier to remove tests that are no longer failing as we improve the test coverage of LLDB on Windows.

This should be merged before swiftlang/swift#83588.

@charles-zablit charles-zablit requested a review from compnerd August 7, 2025 12:26
@charles-zablit charles-zablit self-assigned this Aug 7, 2025
@charles-zablit charles-zablit requested a review from a team as a code owner August 7, 2025 12:26
@charles-zablit charles-zablit changed the title [windows] move llvm test overrides to the llvm-project repository [windows] move windows-llvm-lit-test-overrides.txt to the llvm-project repository Aug 7, 2025
@charles-zablit
Copy link
Author

@swift-ci please test

Copy link
Member

@weliveindetail weliveindetail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@@ -0,0 +1,184 @@
# build.ps1 overrides the status of each test in this file when LLVM tests are run with lit.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the new name should reflect that the overrides are Swift specific. This was obvious in the old location. In the new location it's obvious that this file if relevant for llvm LIT test. It's also not clear anymore where to find build.ps1.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks!

@charles-zablit charles-zablit force-pushed the charles-zablit/windows/move-llvm-overrides-to-llvm-repo branch from ccf592b to 57db1c1 Compare August 7, 2025 13:38
@charles-zablit
Copy link
Author

To explain the motivation, consider #11096. It's failing because it fixes 2 tests which are marked as xfail in windows-llvm-lit-test-overrides.txt. There is a chicken and egg problem where we have to remove the xfail in swiftlang/swift and then cherry-pick to release/6.2. However that would cause the CI to fail while we merge #11096.

This patch removes this problem altogether.

@charles-zablit
Copy link
Author

@swift-ci please test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should make sure that the appropriate version is also merged into stable/21.x. (CC: @AnthonyLatsis @bnbarham)

@adrian-prantl adrian-prantl merged commit 3c0ab62 into swiftlang:swift/release/6.2 Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants