-
Notifications
You must be signed in to change notification settings - Fork 344
[windows] move windows-llvm-lit-test-overrides.txt to the llvm-project repository #11143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[windows] move windows-llvm-lit-test-overrides.txt to the llvm-project repository #11143
Conversation
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
@@ -0,0 +1,184 @@ | |||
# build.ps1 overrides the status of each test in this file when LLVM tests are run with lit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe the new name should reflect that the overrides are Swift specific. This was obvious in the old location. In the new location it's obvious that this file if relevant for llvm LIT test. It's also not clear anymore where to find build.ps1
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
ccf592b
to
57db1c1
Compare
To explain the motivation, consider #11096. It's failing because it fixes 2 tests which are marked as This patch removes this problem altogether. |
@swift-ci please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should make sure that the appropriate version is also merged into stable/21.x. (CC: @AnthonyLatsis @bnbarham)
This patch moves the file
windows-llvm-lit-test-overrides.txt
fromswiftlang/swift
toswiftlang/llvm-project
.As it controls the failing and skipped tests of LLVM, this will make it easier to remove tests that are no longer failing as we improve the test coverage of LLDB on Windows.
This should be merged before swiftlang/swift#83588.