[windows] move windows-llvm-lit-test-overrides.txt to the llvm-project repository #83588
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weliveindetail
approved these changes
Aug 7, 2025
utils/build.ps1
Outdated
| @@ -2028,7 +2028,7 @@ function Test-Compilers([Hashtable] $Platform, [string] $Variant, [switch] $Test | |||
| $Targets += @("check-lldb") | |||
|
|
|||
| # Override test filter for known issues in downstream LLDB | |||
| Load-LitTestOverrides $PSScriptRoot/windows-llvm-lit-test-overrides.txt | |||
| Load-LitTestOverrides [IO.Path]::GetFullPath([IO.Path]::Combine($PSScriptRoot, "..", "..", "llvm-project", "lldb", "test", "windows-llvm-lit-test-overrides.txt")) | |||
There was a problem hiding this comment.
Maybe the new name should reflect that the overrides are Swift specific
There was a problem hiding this comment.
Fixed, thanks! This is now windows-swift-llvm-lit-test-overrides.txt
charles-zablit
force-pushed
the
charles-zablit/windows/move-llvm-overrides-to-llvm-repo
branch
from
ec1a0fe to
312ac1b
Compare
compnerd
approved these changes
Aug 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the file
windows-llvm-lit-test-overrides.txtfrom swiftlang/swift to swiftlang/llvm-project.As it controls the failing and skipped tests of LLVM, this will make it easier to remove tests that are no longer failing as we improve the test coverage of LLDB on Windows.
This should be merged after swiftlang/llvm-project#11143.