makeOptions: Fix CMake build for stable/21.x rebranch #1975
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the code to work with both stable/20240723 and stable/21.x after llvm/llvm-project#119198. This saves us from having to cut and qualify a rebranch branch for swift-driver.
This was referenced Aug 26, 2025
bnbarham
approved these changes
Aug 26, 2025
Contributor
bnbarham
left a comment
bnbarham
left a comment
There was a problem hiding this comment.
We'll make sure to remove the <21 side after rebranch is merged. @AnthonyLatsis did you verify that the same options get generated for both main + rebranch?
Contributor
|
@swift-ci please test |
Contributor
Author
Verified just now. |
Contributor
Author
|
Also verified that the other 2 commits do not affect generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the code to work with both stable/20240723 and stable/21.x after llvm/llvm-project#119198. This saves us from having to cut and qualify a rebranch branch for swift-driver.