Add Review Manager field to header of Swift Testing proposal template #2748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmontgomery
added
evolution process
grynspan
approved these changes
Mar 20, 2025
Contributor
Author
|
@dempseyatgithub FYI: I don't expect this to impact swift-evolution-metadata-extractor, especially since it's not yet ingesting any of these templates, but wanted to give a heads up as promised. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently added a proposal template for Swift Testing in #2709, but it didn't include a header field titled "Review Manager". Prior to Swift Testing adopting the Swift evolution process (a change which happened in #2729) we didn't formally define the role of a review manager, but now we have that role and the template should include this field.
I also filled in the field for ST-0008: Exit Tests which is missing it.