Skip to content

Add Review Manager field to header of Swift Testing proposal template #2748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Add Review Manager field to header of Swift Testing proposal template #2748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions proposal-templates/0000-swift-testing-template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Proposal: [ST-NNNN](NNNN-filename.md)
* Authors: [Author 1](https://github.com/author1), [Author 2](https://github.com/author2)
* Review Manager: TBD
* Status: **Awaiting implementation** or **Awaiting review**
* Bug: _if applicable_ [swiftlang/swift-testing#NNNNN](https://github.com/swiftlang/swift-testing/issues/NNNNN)
* Implementation: [swiftlang/swift-testing#NNNNN](https://github.com/swiftlang/swift-testing/pull/NNNNN)
Expand All @@ -14,8 +15,10 @@ except for the section headers and the header fields above. For example, you
should delete everything from this paragraph down to the Introduction section
below.

As a proposal author, you should fill out all of the header fields. Delete any
header fields marked _if applicable_ that are not applicable to your proposal.
As a proposal author, you should fill out all of the header fields except
`Review Manager`. The review manager will set that field and change several
others as part of initiating the review. Delete any header fields marked _if
applicable_ that are not applicable to your proposal.

When sharing a link to the proposal while it is still a PR, be sure to share a
live link to the proposal, not an exact commit, so that readers will always see
Expand Down Expand Up @@ -181,4 +184,5 @@ were incorporated into the proposal as it developed, take a moment here to thank
them for their contributions. This is a collaborative process, and everyone's
input should receive recognition!

Generally, you should not acknowledge anyone who is listed as a co-author.
Generally, you should not acknowledge anyone who is listed as a co-author or as
the review manager.
1 change: 1 addition & 0 deletions proposals/testing/0008-exit-tests.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

* Proposal: [ST-0008](https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0008-exit-tests.md)
* Authors: [Jonathan Grynspan](https://github.com/grynspan)
* Review Manager: [Maarten Engels](https://github.com/maartene)
* Status: **Active Review (March 21...April 8, 2025)**
* Bug: [apple/swift-testing#157](https://github.com/apple/swift-testing/issues/157)
* Implementation: [apple/swift-testing#324](https://github.com/swiftlang/swift-testing/pull/324)
Expand Down